Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: laurentgo <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-659-drill@git.apache.org>
In-Reply-To: <git-pr-659-drill@git.apache.org>
Subject: [GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...
Content-Type: text/plain
Message-Id: <20161121192424.EB9CDE00E5@git1-us-west.apache.org>
Date: Mon, 21 Nov 2016 19:24:24 +0000 (UTC)
archived-at: Mon, 21 Nov 2016 19:24:27 -0000

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/659#discussion_r88956264
  
    --- Diff: contrib/native/client/readme.macos ---
    @@ -67,13 +72,37 @@ XCode IDE
     ---------
       You can open the drillclient.xcodeproj file in the XCode ide and run/debug as with any other command line app
     
    -Test
    -----
    +2.3.1.2 Build using MAKE
    +========================
    +(Optional) Refresh protobuf source files
    +----------------------------------------
    +When changes have been introduced to the protocol module, you might need to refresh the protobuf C++ source files too.
    +    $> cd DRILL_DIR/contrib/native/client
    +    $> mkdir build
    +    $> cd build && cmake3 -G "Unix Makefiles" ..
    +    $> make cpProtobufs
    +
    +Open a pull request with the changes to DRILL_DIR/contrib/native/client/src/protobuf
    +
    +Build drill client
    +-------------------
    +    $> cd DRILL_DIR/contrib/native/client
    +    $> mkdir build
    +    $> cd build && cmake3 -G "Unix Makefiles" -D CMAKE_BUILD_TYPE=Debug ..
    +    $> make
    +
    +
    +2.4 Test
    +--------
     Run query submitter from the command line
       $> querySubmitter query='select * from dfs.`/Users/pchandra/work/data/tpc-h/customer.parquet`' type=sql connectStr=local=10.250.0.146:31010 api=async logLevel=trace user=yourUserName password=yourPassWord
     
    -Valgrind
    ---------
    -  If you can get valgrind to build and run on macos, please update the instuctions here
    +2.5 Valgrind
    +------------
    +  Valgrind is available only for MacOs 10.11 or earlier. Install valgrind using brew
    --- End diff --
    
    According to valgrind website, 3.12.0 release (available through brew) has limited support for 10.11 and 10.12. I haven't tested it yet (my main laptop is still on 10.11)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---