Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-647-drill@git.apache.org>
In-Reply-To: <git-pr-647-drill@git.apache.org>
Subject: [GitHub] drill issue #647: DRILL-4935 Allow Drill to advertise a specific hostname to...
Content-Type: text/plain
Message-Id: <20161108192352.4D6BAE0999@git1-us-west.apache.org>
Date: Tue,  8 Nov 2016 19:23:52 +0000 (UTC)
archived-at: Tue, 08 Nov 2016 19:23:54 -0000

Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/647
  
    Two ways to test.
    
    First, try the fix manually. Start Drill once without the env var set to ensure Drill uses the default. Then, set the env var and ensure that Drill uses the correct value.
    
    Second, would be a unit test. I'm not familiar with any existing ZK unit tests. Do any of the other committers know if we have such tests? Something that validates Drillbit registration, etc? If so, then that test can be modified for this use case.
    
    But, there is one gotcha: in Java, env vars are read-only, there is no way to set env vars in a test (that I've ever found.)  Anyone have a work-around?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---