Return-Path: <dev-return-25091-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 21439200BB6
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri,  4 Nov 2016 16:51:08 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 20058160B07; Fri,  4 Nov 2016 15:51:08 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 67352160AFE
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  4 Nov 2016 16:51:07 +0100 (CET)
Received: (qmail 26664 invoked by uid 500); 4 Nov 2016 15:51:03 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 25751 invoked by uid 99); 4 Nov 2016 15:51:03 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2016 15:51:03 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id A76BCE3813; Fri,  4 Nov 2016 15:51:02 +0000 (UTC)
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-482-drill@git.apache.org>
In-Reply-To: <git-pr-482-drill@git.apache.org>
Subject: [GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...
Content-Type: text/plain
Message-Id: <20161104155102.A76BCE3813@git1-us-west.apache.org>
Date: Fri,  4 Nov 2016 15:51:02 +0000 (UTC)
archived-at: Fri, 04 Nov 2016 15:51:08 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r86573840
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -17,17 +17,56 @@
       <a href="/queries">back</a><br/>
       <div class="page-header">
       </div>
    -  <div class="table-responsive">
    -    <table class="table table-hover">
    -      <tbody>
    -        <#list model as stat>
    -          <tr>
    -            <td style="border:none;"><b>${stat.getName()}</b></td>
    -            <td style="border:none; font-family: Courier;">${stat.getValue()}</td>
    -          </tr>
    -        </#list>
    -      </tbody>
    -    </table>
    +
    +  <#list model.getDrillbits() as drillbit>
    +    <#if !drillbit.isVersionMatch()>
    +      <div id="message" class="alert alert-danger alert-dismissable">
    +        <button type="button" class="close" data-dismiss="alert" aria-hidden="true">&times;</button>
    +        <strong>Drillbits in the cluster have different versions.</strong>
    +      </div>
    +      <#break>
    +    </#if>
    +  </#list>
    +
    +  <div class="row">
    +    <div class="col-md-6">
    +      <h3>General Info</h3>
    +      <div class="table-responsive">
    +        <table class="table table-hover">
    +          <tbody>
    +            <#assign props = model.getProps()>
    +            <#list props?keys as key>
    +              <tr>
    +                <td style="border:none;"><b>${key}</b></td>
    +                <td style="border:none; font-family: Courier;">${props[key]}</td>
    +              </tr>
    +            </#list>
    +          </tbody>
    +        </table>
    +      </div>
    +  </div>
    +  <div class="col-md-6">
    +    <h3>List of Drillbits</h3>
    +    <div class="table-responsive">
    +      <table class="table table-hover">
    --- End diff --
    
    Better table would be to have columns for each field rather than putting all Drillbit data into a single column. (See note elsewhere.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---