Return-Path: <dev-return-25005-archive-asf-public=cust-asf.ponee.io@drill.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 94C56200BC3
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu,  3 Nov 2016 17:28:57 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 938CF160AE5; Thu,  3 Nov 2016 16:28:57 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0DB00160AFF
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  3 Nov 2016 17:28:56 +0100 (CET)
Received: (qmail 84467 invoked by uid 500); 3 Nov 2016 16:28:56 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 83968 invoked by uid 99); 3 Nov 2016 16:28:55 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2016 16:28:55 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 9A21BE0BB1; Thu,  3 Nov 2016 16:28:55 +0000 (UTC)
From: amansinha100 <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-637-drill@git.apache.org>
In-Reply-To: <git-pr-637-drill@git.apache.org>
Subject: [GitHub] drill pull request #637: Drill 1950 : Parquet row group filter pushdown. 
Content-Type: text/plain
Message-Id: <20161103162855.9A21BE0BB1@git1-us-west.apache.org>
Date: Thu,  3 Nov 2016 16:28:55 +0000 (UTC)
archived-at: Thu, 03 Nov 2016 16:28:57 -0000

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/637#discussion_r86377522
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java ---
    @@ -346,6 +355,20 @@ static RuleSet getPruneScanRules(OptimizerRulesContext optimizerRulesContext) {
       }
     
       /**
    +   *   Get an immutable list of partition pruning rules that will be used in logical planning.
    +   */
    +  static RuleSet getPhysicalPruneScanRules(OptimizerRulesContext optimizerRulesContext) {
    +    final ImmutableSet<RelOptRule> pruneRules = ImmutableSet.<RelOptRule>builder()
    +        .add(
    +            ParquetPushDownFilter.getFilterOnProject(optimizerRulesContext),
    --- End diff --
    
    The ParquetFilterPushdown rule should ideally be done during logical planning since this rule affects selectivity.  I understand that you saw some plan regressions if this was done during logical planning.  For now, we can leave this in the physical planning phase (add some comments here) and create a JIRA to re-visit .  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---