drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Rogers (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-5083) IteratorValidator does not handle RecordIterator cleanup call to next( )
Date Tue, 29 Nov 2016 01:03:58 GMT
Paul Rogers created DRILL-5083:
----------------------------------

             Summary: IteratorValidator does not handle RecordIterator cleanup call to next(
)
                 Key: DRILL-5083
                 URL: https://issues.apache.org/jira/browse/DRILL-5083
             Project: Apache Drill
          Issue Type: Bug
    Affects Versions: 1.8.0
            Reporter: Paul Rogers
            Priority: Minor


This one is very confusing...

In a test with a MergeJoin and external sort, operators are stacked something like this:
{code}
Screen
- MergeJoin
- - External Sort
...
{code}

Using the injector to force a OOM in spill, the external sort threw a UserException up the
stack. This was handed by:

{code}
IteratorValidatorBatchIterator.next( )
RecordIterator.clearInflightBatches( )
RecordIterator.close( )
MergeJoinBatch.close( )
{code}

Which does the following:

{code}
      // Check whether next() should even have been called in current state.
      if (null != exceptionState) {
        throw new IllegalStateException(
{code}

But, the exceptionState is set, so we end up throwing an IllegalStateException during cleanup.

Seems the code should agree: if {{next( )}} will be called during cleanup, then {{next( )}}
should gracefully handle that case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message