drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...
Date Tue, 22 Nov 2016 00:47:20 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/659#discussion_r88991123
  
    --- Diff: contrib/native/client/readme.boost ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +Building Boost for Drill on MacOs/Linux
    +--------------------------------
    +
    +These instructions are using Boost version 1.60.0 which is recommended
    +
    +Assuming there is a BOOST_BUILD_DIR 
    +
    +$ cd $BOOST_BUILD_DIR
    +$ tar zxf boost_1_60_0.tar.gz
    +$ cd $BOOST_BUILD_DIR/boost_1_60_0
    +$ ./bootstrap.sh --prefix=$BOOST_BUILD_DIR/boost_1_60_0/
    +$ ./b2 tools/bcp
    +$ cd $BOOST_BUILD_DIR/drill_boost_1_60_0
    +
    +# Use boost bcp to rename the boost namespace to drill_boost
    +# the following builds a subset of boost without icu. You may need to add more modules
to include icu. 
    +# bcp documentation can be found here: http://www.boost.org/doc/libs/1_60_0/tools/bcp/doc/html/index.html
    +
    +$ $BOOST_BUILD_DIR/boost_1_60_0/dist/bin/bcp --namespace=drill_boost --namespace-alias
--boost=$BOOST_BUILD_DIR/boost_1_60_0/ shared_ptr random context chrono date_time regex system
timer thread asio smart_ptr bind config build regex config assign $BOOST_BUILD_DIR/drill_boost_1_60_0

    --- End diff --
    
    Good catch. I started with the required components, let bcp figure out the dependencies,
compiled the client (using only the files included by bcp) and added the dependencies that
bcp didn't find. So multiprecision and functional are probably included, but it's probably
better to include them explicitly.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message