drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...
Date Mon, 21 Nov 2016 17:48:25 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/659#discussion_r88947835
  
    --- Diff: contrib/native/client/CMakeLists.txt ---
    @@ -88,19 +88,28 @@ if(MSVC)
         set(Boost_USE_STATIC_LIBS ON)
         set(Boost_USE_MULTITHREADED ON)
         set(Boost_USE_STATIC_RUNTIME OFF)
    +elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
    +    set(Boost_USE_STATIC_LIBS ON)
    +    set(Boost_USE_MULTITHREADED ON)
    +    #    To build a production version, the macos build must use a shaded version
    +    #    of boost. Arbirtarily, we choose the new namspace to be drill_boost.
    +    #    See the instructions in the readme for the mac and rebuild boost. Then
    +    #    uncomment the line below to build
    +    #    set(Boost_NAMESPACE drill_boost)
    --- End diff --
    
    There is no change needed to the source. The bcp option namespace-alias aliases the boost
namespace to the namespace you provide, so no code change is needed. (Someone at boost thought
this thru!) 
    Added a linux portion. Can you please doubecheck?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message