drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #659: DRILL-5050: C++ client library has symbol resolutio...
Date Sat, 19 Nov 2016 00:28:11 GMT
Github user laurentgo commented on a diff in the pull request:

    --- Diff: contrib/native/client/CMakeLists.txt ---
    @@ -88,19 +88,28 @@ if(MSVC)
         set(Boost_USE_STATIC_LIBS ON)
         set(Boost_USE_MULTITHREADED ON)
         set(Boost_USE_STATIC_RUNTIME OFF)
    +elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
    +    set(Boost_USE_STATIC_LIBS ON)
    +    set(Boost_USE_MULTITHREADED ON)
    +    #    To build a production version, the macos build must use a shaded version
    +    #    of boost. Arbirtarily, we choose the new namspace to be drill_boost.
    +    #    See the instructions in the readme for the mac and rebuild boost. Then
    +    #    uncomment the line below to build
    +    #    set(Boost_NAMESPACE drill_boost)
    --- End diff --
    if the boost namespace is changed, I guess the code should be changed too? But it means
that all boost symbols are changed too (included boost::shared_ptr<> which are part
of the public API), correct?
    In any case, can you also provide the changes to the source files?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message