drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kkhatua <...@git.apache.org>
Subject [GitHub] drill pull request #655: DRILL-5047: When session option is string, query pr...
Date Fri, 18 Nov 2016 05:52:10 GMT
Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/655#discussion_r88602974
  
    --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
    @@ -132,7 +132,7 @@
                     <#list model.getOptionList() as option>
                       <tr>
                         <td>${option.getName()}</td>
    -                    <td>${option.getValue()?c}</td>
    +                    <td>${option.getValue()?string}</td>
    --- End diff --
    
    Tried this out. All the options take non-null values.  Any attempt to set a property (String,
for e.g.) to null failed. So, I guess as long as a property takes only non-null values, things
should be fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message