drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #655: DRILL-5047: When session option is string, query pr...
Date Thu, 17 Nov 2016 19:31:54 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/resources/rest/profile/profile.ftl ---
    @@ -132,7 +132,7 @@
                     <#list model.getOptionList() as option>
    -                    <td>${option.getValue()?c}</td>
    +                    <td>${option.getValue()?string}</td>
    --- End diff --
    For [the documentation](http://freemarker.org/docs/ref_builtins.html), `?string` is deprecated
for certain type. Why isn't `${option.getValue()}` or `${option.getValue().toString()}` sufficient?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message