drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xhochy <...@git.apache.org>
Subject [GitHub] drill issue #649: DRILL-4979: Make port of the DataConnection configurable
Date Wed, 09 Nov 2016 20:48:11 GMT
Github user xhochy commented on the issue:

    https://github.com/apache/drill/pull/649
  
    No, this patch is actually functioning as the data port is already included in the probuf:
https://github.com/apache/drill/blob/master/protocol/src/main/protobuf/Coordination.proto#L11
The `+1 logic` is only used in the initialization code for the port.
    
    Also I did a test run with 5 drillbits and random dataports assigned to them. They each
were able to talk to them showing that the correct ports are communicated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message