drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #644: DRILL-4980: Upgrading of the approach of parquet da...
Date Wed, 09 Nov 2016 16:58:55 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/644#discussion_r87232983
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetWriter.java
---
    @@ -40,6 +40,16 @@
     public class ParquetWriter extends AbstractWriter {
       static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(ParquetWriter.class);
     
    +/** Version of Drill's Parquet writer. Increment this version (by 1) any time we make
any format change to the file.
    + * Format changes include
    + * 1) supporting new data types,
    + * 2) changes to the format of data fields,
    + * 3) adding new metadata to the file footer, etc.
    + * Newer readers must be able to read old files. The Writer version tells the Parquet
reader how to interpret fields
    --- End diff --
    
    This is Javadoc, so needs HTML formatting. For the list:
    
        <ul>
        <li>Supporting new data types,</li>
        ...
        </ul>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message