drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #648: DRILL-5015: Randomly select the drillbit from the l...
Date Tue, 08 Nov 2016 22:54:15 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/648#discussion_r87098478
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
    @@ -223,19 +223,65 @@ public void connect(Properties props) throws RpcException {
         connect(null, props);
       }
     
    +  /**
    +   * Function to populate the endpointList with information of all the drillbits
    +   * provided in the connection string by client
    +   * @param endpointList - ArrayList of DrillbitEndpoints
    +   * @param drillbits - One or more drillbit ip[:port] provided in connection string
    +   */
    +  public void populateEndpointsList(ArrayList<DrillbitEndpoint> endpointList, String
drillbits){
    +
    +    // If no information about drillbits is provided then just return empty list.
    +    if(drillbits == null || drillbits.length() == 0){
    --- End diff --
    
    drillbits.length( ) == 0 --> drillbits.trim( ).isEmpty( )
    
    The trim removes any bogus white space. IsEmpty( ) is a shorthand for length( ) == 0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message