drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From harrisonmebane <...@git.apache.org>
Subject [GitHub] drill pull request #647: DRILL-4935 Allow Drill to advertise a specific host...
Date Mon, 07 Nov 2016 22:24:48 GMT
Github user harrisonmebane commented on a diff in the pull request:

    https://github.com/apache/drill/pull/647#discussion_r86883806
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -49,6 +49,7 @@
       String USER_RPC_TIMEOUT = "drill.exec.rpc.user.timeout";
       String METRICS_CONTEXT_NAME = "drill.exec.metrics.context";
       String USE_IP_ADDRESS = "drill.exec.rpc.use.ip";
    +  String BIT_ADVERTISED_HOST = "drill.exec.rpc.bit.advertised.host";
    --- End diff --
    
    @paul-rogers Thank you for your helpful suggestions.  I understand what you are saying,
and indeed, I was using exactly the flow you outlined above for my own use case.
    
    Let me make sure I understand what you are proposing.  We can either:
    
    1. Access the host name as an environment variable, in which case we could access it via
`System.getEnv(...)`
    2. Pass the host name in as a system variable (``-Ddrill.exec.rpc.bit.advertised-host=myhost`),
which could just override the parameter I've already specified in `ExecConstants.java`
    
    In either case, I guess I don't understand why I'd need to add anything to `drill-env.sh`,
unless you mean just to add a commented out line for documentation purposes.  In the second
case, is there any change I would need to make at all?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message