drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #644: DRILL-4980: Upgrading of the approach of parquet da...
Date Fri, 04 Nov 2016 19:17:55 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/644#discussion_r86615126
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -927,15 +927,11 @@ public void setMax(Object max) {
         @JsonProperty List<ParquetFileMetadata_v2> files;
         @JsonProperty List<String> directories;
         @JsonProperty String drillVersion;
    -    @JsonProperty boolean isDateCorrect;
    +    @JsonProperty int writerVersion;
    --- End diff --
    
    I tried to figure out this and found that for reading parquet footer this class isn't
used. For that purposes used `ParquetMetadata` from parquet-hadoop-1.8.1-drill-r0.jar.
    This class used for entire parquet directory with metadata cache file. When it is absent
an empty of this class is created. 
    I added some javadoc. Hope it will help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message