drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...
Date Fri, 04 Nov 2016 15:59:08 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r86575055
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -218,13 +218,18 @@ private void javaPropertiesToSystemOptions() {
       }
     
       /**
    -   * If cluster version is the same as default, update option to current drillbit version.
    +   * If cluster version is the same as default, updates option to current drillbit version.
    +   * Since getOption and setOption are separate calls, raise condition might occur
    +   * when several drillbits are registering at the same time.
    +   * It is assumed that the first drillbit in cluster sets cluster version
    +   * but when the raise condition occurs, it might be the second or the third etc.
    +   * This behaviour does not impose significant impact, since the main goal is to detect
mismatching versions.
        */
    -  private void checkAndUpdateClusterVersionOption(OptionManager optionManager, DrillbitEndpoint
drillbitEndpoint) {
    -    OptionValue versionOption = optionManager.getOption(ExecConstants.CLUSTER_VERSION);
    +  private void checkAndUpdateClusterVersionOption(OptionManager systemOptions, DrillbitEndpoint
drillbitEndpoint) {
    --- End diff --
    
    How can this work? Consider this:
    
    1. Start a new cluster.
    2. A Drillbit registers. It sets the cluster version.
    3. A second Drillbit registers. Does it reset the version? Or, does it accept that the
first has already set the version?
    4. Shut down the cluster.
    5. Upgrade Drill to a new version.
    6. Start the first Drillbit.
    7. Does this Drillbit overwrite the cluster version? Or, accept the existing (old) version?
    
    Note that steps 3 and 7 are identical from ZK's perspective.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message