drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...
Date Fri, 04 Nov 2016 15:51:02 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r86566329
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
    @@ -252,6 +252,8 @@ public DrillbitEndpoint apply(ServiceInstance<DrillbitEndpoint>
input) {
               builder.append(bit.getControlPort());
               builder.append(':');
               builder.append(bit.getDataPort());
    +          builder.append(". Version - ");
    +          builder.append(bit.getVersion());
    --- End diff --
    
    Actually, how is this even possible? Drill bits do not advertise their version in ZK,
do they? How will we get the version of a remote Drillbit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message