drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...
Date Fri, 04 Nov 2016 15:51:02 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r86573108
  
    --- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
    @@ -17,17 +17,56 @@
       <a href="/queries">back</a><br/>
       <div class="page-header">
       </div>
    -  <div class="table-responsive">
    -    <table class="table table-hover">
    -      <tbody>
    -        <#list model as stat>
    -          <tr>
    -            <td style="border:none;"><b>${stat.getName()}</b></td>
    -            <td style="border:none; font-family: Courier;">${stat.getValue()}</td>
    -          </tr>
    -        </#list>
    -      </tbody>
    -    </table>
    +
    +  <#list model.getDrillbits() as drillbit>
    +    <#if !drillbit.isVersionMatch()>
    +      <div id="message" class="alert alert-danger alert-dismissable">
    +        <button type="button" class="close" data-dismiss="alert" aria-hidden="true">&times;</button>
    +        <strong>Drillbits in the cluster have different versions.</strong>
    +      </div>
    +      <#break>
    +    </#if>
    +  </#list>
    +
    +  <div class="row">
    +    <div class="col-md-6">
    +      <h3>General Info</h3>
    +      <div class="table-responsive">
    +        <table class="table table-hover">
    +          <tbody>
    +            <#assign props = model.getProps()>
    +            <#list props?keys as key>
    +              <tr>
    +                <td style="border:none;"><b>${key}</b></td>
    +                <td style="border:none; font-family: Courier;">${props[key]}</td>
    --- End diff --
    
    Styles should be pulled out into the style sheet. Very hard to maintain inline styles.
And, why do we need to use a different font?
    
    This is web UI, so it is not ensured that every browser has Courier. Instead, standard
practice is to list multiple fonts, with a fallback to, say, monospace. See [this page](http://www.w3schools.com/cssref/css_websafe_fonts.asp).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message