drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #611: Drill-4800: Improve parquet reader performance
Date Thu, 03 Nov 2016 18:05:56 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/611#discussion_r86393658
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
---
    @@ -370,7 +400,11 @@ public void clearDictionaryBuffers() {
       }
     
       public void clear(){
    -    this.dataReader.clear();
    +    try {
    +      this.dataReader.close();
    +    } catch (IOException e) {
    +      //TODO: Throw UserException
    --- End diff --
    
    Reader IO errors on close are benign. Change comment to
    
    // Ignore
    
    ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message