drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #637: Drill 1950 : Parquet row group filter pushdown.
Date Thu, 03 Nov 2016 16:28:55 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/637#discussion_r86377522
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerPhase.java
---
    @@ -346,6 +355,20 @@ static RuleSet getPruneScanRules(OptimizerRulesContext optimizerRulesContext)
{
       }
     
       /**
    +   *   Get an immutable list of partition pruning rules that will be used in logical
planning.
    +   */
    +  static RuleSet getPhysicalPruneScanRules(OptimizerRulesContext optimizerRulesContext)
{
    +    final ImmutableSet<RelOptRule> pruneRules = ImmutableSet.<RelOptRule>builder()
    +        .add(
    +            ParquetPushDownFilter.getFilterOnProject(optimizerRulesContext),
    --- End diff --
    
    The ParquetFilterPushdown rule should ideally be done during logical planning since this
rule affects selectivity.  I understand that you saw some plan regressions if this was done
during logical planning.  For now, we can leave this in the physical planning phase (add some
comments here) and create a JIRA to re-visit .  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message