drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chunhui-shi <...@git.apache.org>
Subject [GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...
Date Tue, 01 Nov 2016 17:48:04 GMT
Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/594#discussion_r85975481
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
    @@ -59,12 +59,13 @@
       private final ListVectorOutput listOutput;
       private final boolean extended = true;
       private final boolean readNumbersAsDouble;
    +  private List<String> path = Lists.newArrayList();
    --- End diff --
    
    Since you are adding a stateful variable 'path', could you add a test with some error
json items injected in the middle to make sure it can still recover and have good status when
the option introduced in DRILL-4653 is enabled ('store.json.reader.skip_invalid_records')
which will skip invalid tokens.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message