drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Tue, 01 Nov 2016 16:38:44 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r85850267
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
    @@ -285,9 +279,14 @@ public synchronized boolean reconnect() {
       }
     
       private void connect(DrillbitEndpoint endpoint) throws RpcException {
    -    final FutureHandler f = new FutureHandler();
    -    client.connect(f, endpoint, props, getUserCredentials());
    -    f.checkedGet();
    +    client.connect(endpoint, parameters, getUserCredentials()).checkedGet();
    +    if (client.serverRequiresAuthentication()) {
    --- End diff --
    
    Yes, notice the checkedGet() call to connect above (and if required to authenticate, the
checkedGet() call to authenticate).
    
    Or am I missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message