Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 96649200BAD for ; Tue, 25 Oct 2016 21:02:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 95073160AFA; Tue, 25 Oct 2016 19:02:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DEE9D160AD8 for ; Tue, 25 Oct 2016 21:02:40 +0200 (CEST) Received: (qmail 40544 invoked by uid 500); 25 Oct 2016 19:02:38 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 40039 invoked by uid 99); 25 Oct 2016 19:02:38 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Oct 2016 19:02:38 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D8340DFAAB; Tue, 25 Oct 2016 19:02:37 +0000 (UTC) From: sudheeshkatkam To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits... Content-Type: text/plain Message-Id: <20161025190237.D8340DFAAB@git1-us-west.apache.org> Date: Tue, 25 Oct 2016 19:02:37 +0000 (UTC) archived-at: Tue, 25 Oct 2016 19:02:41 -0000 Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r84970266 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java --- @@ -207,6 +210,21 @@ private void javaPropertiesToSystemOptions() { } /** + * If cluster version is the same as default, update option to current drillbit version. + */ + private void checkAndUpdateClusterVersionOption(OptionManager optionManager, DrillbitEndpoint drillbitEndpoint) { --- End diff -- Doc: rename `optionManager` to `systemOptions` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---