Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: laurentgo <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-622-drill@git.apache.org>
In-Reply-To: <git-pr-622-drill@git.apache.org>
Subject: [GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...
Content-Type: text/plain
Message-Id: <20161019191440.DBD53DFCF2@git1-us-west.apache.org>
Date: Wed, 19 Oct 2016 19:14:40 +0000 (UTC)
archived-at: Wed, 19 Oct 2016 19:14:43 -0000

Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/622#discussion_r84145567
  
    --- Diff: exec/jdbc-all/src/test/java/org/apache/drill/jdbc/ITTestShadedJar.java ---
    @@ -67,6 +70,33 @@ public void run() {
       }
     
       @Test
    +  public void testDatabaseVersion() throws Exception {
    +
    +    // print class path for debugging
    +    System.out.println("java.class.path:");
    +    System.out.println(System.getProperty("java.class.path"));
    --- End diff --
    
    this class needs a serious refactoring, but I'm hesitant of doing it in that patch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---