Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: parthchandra <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-600-drill@git.apache.org>
In-Reply-To: <git-pr-600-drill@git.apache.org>
Subject: [GitHub] drill pull request #600: DRILL-4373: Drill and Hive have incompatible timest...
Content-Type: text/plain
Message-Id: <20161013184717.C4ABEDFE13@git1-us-west.apache.org>
Date: Thu, 13 Oct 2016 18:47:17 +0000 (UTC)
archived-at: Thu, 13 Oct 2016 18:47:20 -0000

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/600#discussion_r83284350
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java ---
    @@ -754,15 +764,45 @@ public void testImpalaParquetVarBinary_DictChange() throws Exception {
         compareParquetReadersColumnar("field_impala_ts", "cp.`parquet/int96_dict_change.parquet`");
       }
     
    +  @Test
    +  public void testImpalaParquetBinaryTimeStamp_DictChange() throws Exception {
    +    try {
    +      test("alter session set %s = true", ExecConstants.PARQUET_READER_INT96_AS_TIMESTAMP);
    +      compareParquetReadersColumnar("field_impala_ts", "cp.`parquet/int96_dict_change.parquet`");
    --- End diff --
    
    This is not a good enough test. Both the baseline and test case queries will use the getDateTimeValueFromBinary method and if there is a bug in that method, the test will still pass as both will produce the same incorrect value. Better to compare with the actual baseline value in the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---