drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...
Date Tue, 18 Oct 2016 22:13:26 GMT
GitHub user laurentgo opened a pull request:

    https://github.com/apache/drill/pull/622

    DRILL-4369: Exchange name and version infos during handshake

    There's no name and version exchanged between client and server over the User RPC
    channel.
    
    On client side, having access to the server name and version is useful to expose it
    to the user (through JDBC or ODBC api like DatabaseMetadata#getDatabaseProductVersion()),
    or to implement fallback strategy when some recent API are not available (like
    metadata API).
    
    On the server side, having access to the client version might be useful for audit
    purposes and eventually to implement fallback strategy if it doesn't require a RPC
    version change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/drill laurent/DRILL-4369-rpc-endpoint-infos

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/622.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #622
    
----
commit 6767082b64684ce519f5101f386d4758cbd5f03c
Author: Laurent Goujon <laurent@dremio.com>
Date:   2016-10-18T22:01:38Z

    DRILL-4369: Exchange name and version infos during handshake
    
    There's no name and version exchanged between client and server over the User RPC
    channel.
    
    On client side, having access to the server name and version is useful to expose it
    to the user (through JDBC or ODBC api like DatabaseMetadata#getDatabaseProductVersion()),
    or to implement fallback strategy when some recent API are not available (like
    metadata API).
    
    On the server side, having access to the client version might be useful for audit
    purposes and eventually to implement fallback strategy if it doesn't require a RPC
    version change.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message