drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jinfeng Ni <...@apache.org>
Subject isDateCorrect field in ParquetTableMetadata
Date Mon, 24 Oct 2016 22:10:00 GMT
Hello All,

DRILL-4203 addressed the date field issue.  In the fix, it introduced
a new field in ParquetTableMetadata_v2 : isDateCorrect.  I have some
difficulty in understanding the meaning of this field.

According to [1], this field is set to false, when Drill gets parquet
metadata from parquet footer.  This field is  set to true in code flow
of [2] and [3], when Drill gets parquet metadata from meta data cache.

Questions I have:
1.  If the parquet files are generated with Drill after DRILL-4203,
Drill still thinks date field is NOT correct (isDateCorrect = false)?
2.  Why does this filed have nothing to do with "autoCorrection" flag
[4]?  If someone turns off autoCorrection, will it have impact on this
"isDateCorrect" flag ?

Thanks in advance for any input,


[1] https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java#L932
[2] https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java#L936
[3] https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java#L187
[4] https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java#L354-L355

View raw message