drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Mon, 31 Oct 2016 20:14:50 GMT
Github user laurentgo commented on a diff in the pull request:

    --- Diff: contrib/native/client/src/clientlib/drillClientImpl.hpp ---
    @@ -564,6 +570,34 @@ class ZookeeperImpl{
             std::string m_rootDir;
    +class SaslAuthenticatorImpl {
    --- End diff --
    I suggest to move it to a separate unit, as the class is fairly complex, and this is an
helper class.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message