drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Date Mon, 31 Oct 2016 20:14:21 GMT
Github user laurentgo commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
    @@ -285,9 +279,14 @@ public synchronized boolean reconnect() {
       private void connect(DrillbitEndpoint endpoint) throws RpcException {
    -    final FutureHandler f = new FutureHandler();
    -    client.connect(f, endpoint, props, getUserCredentials());
    -    f.checkedGet();
    +    client.connect(endpoint, parameters, getUserCredentials()).checkedGet();
    +    if (client.serverRequiresAuthentication()) {
    --- End diff --
    what if the server doesn't require authentication, shouldn't the client wait too?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message