drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #611: Drill-4800: Improve parquet reader performance
Date Wed, 26 Oct 2016 16:01:23 GMT
Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/611#discussion_r85136996
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java
---
    @@ -174,4 +191,11 @@ public DrillFileSystem newFileSystem(Configuration conf) throws IOException
{
         return fs;
       }
     
    +  @Override
    +  public DrillFileSystem newNonTrackingFileSystem(Configuration conf) throws IOException
{
    +    Preconditions.checkState(fs == null, "Tried to create a second FileSystem. Can only
be called once per OperatorContext");
    +    fs = new DrillFileSystem(conf, null);
    +    return fs;
    +  }
    +
    --- End diff --
    
    Extra lines here and bunch of other places in the code. Please check and fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message