drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #610: DRILL-4674: Allow casting to boolean the same liter...
Date Wed, 26 Oct 2016 02:08:36 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/610#discussion_r85036776
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanType.java
---
    @@ -0,0 +1,67 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.expr.fn.impl;
    +
    +import java.util.Arrays;
    +import java.util.List;
    +
    +/**
    + * Enum that contains two boolean types: TRUE and FALSE.
    + * Each has numeric representation and list of allowed literals.
    + * List of literals is formed according to
    + * {@link <a href="https://www.postgresql.org/docs/9.6/static/datatype-boolean.html">Postgre
Documentation</a>}
    + */
    +public enum BooleanType {
    +  TRUE(1, Arrays.asList("t", "true", "y", "yes", "on", "1")),
    +  FALSE(0, Arrays.asList("f", "false", "n", "no", "off", "0"));
    +
    +  private int numericValue;
    +  private List<String> literals;
    +
    +  BooleanType(int numericValue, List<String> literals) {
    +    this.numericValue = numericValue;
    +    this.literals = literals;
    +  }
    +
    +  public int getNumericValue() {
    +      return numericValue;
    --- End diff --
    
    Please correct alignment here and in getLiterals()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message