drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request #482: DRILL-4604: Generate warning on Web UI if drillbits...
Date Tue, 25 Oct 2016 19:02:37 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r84976814
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -207,6 +210,21 @@ private void javaPropertiesToSystemOptions() {
       }
     
       /**
    +   * If cluster version is the same as default, update option to current drillbit version.
    +   */
    +  private void checkAndUpdateClusterVersionOption(OptionManager optionManager, DrillbitEndpoint
drillbitEndpoint) {
    +    OptionValue versionOption = optionManager.getOption(ExecConstants.CLUSTER_VERSION);
    +    OptionValidator validator = SystemOptionManager.getValidator(ExecConstants.CLUSTER_VERSION);
    +    if (versionOption.equals(validator.getDefault())) {
    +      optionManager.setOption(OptionValue.createOption(
    --- End diff --
    
    Add a comment in code about what happens when multiple drillbits try to set the cluster
version (since `getOption` and `setOption` are separate calls).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message