drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Serhii-Harnyk <...@git.apache.org>
Subject [GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...
Date Fri, 21 Oct 2016 16:11:12 GMT
Github user Serhii-Harnyk commented on a diff in the pull request:

    https://github.com/apache/drill/pull/594#discussion_r84508112
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
    @@ -131,14 +139,33 @@ public void ensureAtLeastOneField(ComplexWriter writer) {
           PathSegment fieldPath = fieldPathList.get(j);
           if (emptyStatus.get(j)) {
             if (allTextMode) {
    -          fieldWriter.varChar(fieldPath.getNameSegment().getPath());
    +          if (checkNullFields(fieldPathList)) {
    +            for (String fieldName : nullableFields) {
    +              fieldWriter.varChar(fieldName);
    +            }
    +          } else {
    +            fieldWriter.varChar(fieldPath.getNameSegment().getPath());
    +          }
             } else {
    -          fieldWriter.integer(fieldPath.getNameSegment().getPath());
    +          if (checkNullFields(fieldPathList)) {
    --- End diff --
    
    Test added


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message