drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request #622: DRILL-4369: Exchange name and version infos during ...
Date Wed, 19 Oct 2016 01:18:13 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/622#discussion_r83982899
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
    @@ -176,6 +180,23 @@ public void setAutoRead(boolean enableAutoRead) {
       }
     
       /**
    +   * Sets the client name.
    +   *
    +   * If not set, default is {@code DrillClient#DEFAULT_CLIENT_NAME}.
    +   *
    +   * @param name the client name
    +   *
    +   * @throws IllegalStateException if called after a connection has been established.
    +   * @throws NullPointerException if client name is empty
    --- End diff --
    
    it should be changed to if client name is null


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message