drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request #597: DRILL-4905: Push down the LIMIT to the parquet read...
Date Fri, 14 Oct 2016 00:18:27 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/597#discussion_r83335163
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetRecordReaderTest.java
---
    @@ -637,7 +637,7 @@ public void testPerformance(@Injectable final DrillbitContext bitContext,
         final FileSystem fs = new CachedSingleFileSystem(fileName);
         final BufferAllocator allocator = RootAllocatorFactory.newRoot(c);
         for(int i = 0; i < 25; i++) {
    -      final ParquetRecordReader rr = new ParquetRecordReader(context, 256000, fileName,
0, fs,
    +      final ParquetRecordReader rr = new ParquetRecordReader(context, 256000, -1, fileName,
0, fs,
    --- End diff --
    
    If no param for "NumRecordsToRead" means rowCount, we do not need to change here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message