drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ppadma <...@git.apache.org>
Subject [GitHub] drill pull request #592: DRILL-4826: Query against INFORMATION_SCHEMA.TABLES...
Date Thu, 13 Oct 2016 22:32:22 GMT
Github user ppadma commented on a diff in the pull request:

    https://github.com/apache/drill/pull/592#discussion_r83323951
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java
---
    @@ -231,4 +231,21 @@ public void dropTable(String tableName) {
         }
         return tables;
       }
    -}
    \ No newline at end of file
    +
    +  public List<Pair<String, Schema.TableType>> getTableNamesAndTypes(boolean
bulkLoad, int bulkSize) {
    +    final List<String> tableNames = Lists.newArrayList(getTableNames());
    +    final List<Pair<String, Schema.TableType>> tableNamesAndTypes = Lists.newArrayList();
    +    final List<Pair<String, ? extends Table>> tables;
    +    if (bulkLoad) {
    +      tables = getTablesByNamesByBulkLoad(tableNames, bulkSize);
    --- End diff --
    
    why do we even have this option to do bulkLoad or not ? why not just do bulkLoad always
?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message