drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #536: DRILL-4699: Add description column to sys.options t...
Date Sat, 08 Oct 2016 04:33:43 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/536#discussion_r82495404
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -237,71 +281,81 @@
        * DEFAULT: 64 MB
        * MAXIMUM: 2048 MB
        */
    -  String NON_BLOCKING_OPERATORS_MEMORY_KEY = "planner.memory.non_blocking_operators_memory";
    -  OptionValidator NON_BLOCKING_OPERATORS_MEMORY = new PowerOfTwoLongValidator(
    -    NON_BLOCKING_OPERATORS_MEMORY_KEY, 1 << 11, 1 << 6);
    +  public static final String NON_BLOCKING_OPERATORS_MEMORY_KEY = "planner.memory.non_blocking_operators_memory";
    +  public static final OptionValidator NON_BLOCKING_OPERATORS_MEMORY = new PowerOfTwoLongValidator(
    +      NON_BLOCKING_OPERATORS_MEMORY_KEY, 1 << 11, 1 << 6);
     
    -  String HASH_JOIN_TABLE_FACTOR_KEY = "planner.memory.hash_join_table_factor";
    -  OptionValidator HASH_JOIN_TABLE_FACTOR = new DoubleValidator(HASH_JOIN_TABLE_FACTOR_KEY,
1.1d);
    +  public static final String HASH_JOIN_TABLE_FACTOR_KEY = "planner.memory.hash_join_table_factor";
    +  public static final OptionValidator HASH_JOIN_TABLE_FACTOR = new DoubleValidator(HASH_JOIN_TABLE_FACTOR_KEY,
1.1d);
     
    -  String HASH_AGG_TABLE_FACTOR_KEY = "planner.memory.hash_agg_table_factor";
    -  OptionValidator HASH_AGG_TABLE_FACTOR = new DoubleValidator(HASH_AGG_TABLE_FACTOR_KEY,
1.1d);
    +  public static final String HASH_AGG_TABLE_FACTOR_KEY = "planner.memory.hash_agg_table_factor";
    +  public static final OptionValidator HASH_AGG_TABLE_FACTOR = new DoubleValidator(HASH_AGG_TABLE_FACTOR_KEY,
1.1d);
     
    -  String AVERAGE_FIELD_WIDTH_KEY = "planner.memory.average_field_width";
    -  OptionValidator AVERAGE_FIELD_WIDTH = new PositiveLongValidator(AVERAGE_FIELD_WIDTH_KEY,
Long.MAX_VALUE, 8);
    +  public static final String AVERAGE_FIELD_WIDTH_KEY = "planner.memory.average_field_width";
    +  public static final OptionValidator AVERAGE_FIELD_WIDTH = new PositiveLongValidator(AVERAGE_FIELD_WIDTH_KEY,
    +      Long.MAX_VALUE, 8);
     
    -  BooleanValidator ENABLE_QUEUE = new BooleanValidator("exec.queue.enable", false);
    -  LongValidator LARGE_QUEUE_SIZE = new PositiveLongValidator("exec.queue.large", 1000,
10);
    -  LongValidator SMALL_QUEUE_SIZE = new PositiveLongValidator("exec.queue.small", 100000,
100);
    -  LongValidator QUEUE_THRESHOLD_SIZE = new PositiveLongValidator("exec.queue.threshold",
    -      Long.MAX_VALUE, 30000000);
    -  LongValidator QUEUE_TIMEOUT = new PositiveLongValidator("exec.queue.timeout_millis",
    -      Long.MAX_VALUE, 60 * 1000 * 5);
    +  public static final BooleanValidator ENABLE_QUEUE = new BooleanValidator("exec.queue.enable",
false);
    +  public static final LongValidator LARGE_QUEUE_SIZE = new PositiveLongValidator("exec.queue.large",
1000, 10,
    +      "Sets the number of large queries that can run concurrently in the cluster. Range:
0 - 1000.");
    +  public static final LongValidator SMALL_QUEUE_SIZE = new PositiveLongValidator("exec.queue.small",
100000, 100,
    +      "Sets the number of small queries that can run concurrently in the cluster. Range:
0 - 100000.");
    +  public static final LongValidator QUEUE_THRESHOLD_SIZE = new PositiveLongValidator("exec.queue.threshold",
    +      Long.MAX_VALUE, 30000000, "Sets the cost threshold, which depends on the complexity
of the queries in" +
    +      " queue, for determining whether query is large or small. Complex queries have
higher thresholds." +
    +      " Range: 0 - 9223372036854775807.");
    +  public static final LongValidator QUEUE_TIMEOUT = new PositiveLongValidator("exec.queue.timeout_millis",
    +      Long.MAX_VALUE, 60 * 1000 * 5, "Indicates how long a query can wait in queue before
the query fails." +
    --- End diff --
    
    Units? Secs? ms?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message