drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #593: DRILL-3178 csv reader should allow newlines inside ...
Date Thu, 06 Oct 2016 23:15:55 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/593#discussion_r82296690
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextInput.java
---
    @@ -88,6 +88,11 @@
       private boolean endFound = false;
     
       /**
    +   * Switch for enabling/disabling new line detection
    --- End diff --
    
    Explain a bit more? Presumably, we already "monitor" and "detect" new lines in some way.
What, specifically does this add? Presumably, it sets the mode to enable new line detection
within quotes (the title of the Jira entry)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message