drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients
Date Thu, 06 Oct 2016 22:08:12 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/565#discussion_r82269228
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java
---
    @@ -118,8 +118,11 @@ public AnonDrillUserPrincipal(final DrillbitContext drillbitContext)
{
         public DrillClient getDrillClient() throws IOException {
           try {
             // Create a DrillClient
    -        drillClient = new DrillClient(drillbitContext.getConfig(),
    -            drillbitContext.getClusterCoordinator(), drillbitContext.getAllocator());
    +        drillClient = DrillClient.newBuilder()
    --- End diff --
    
    Is the context something we should expose as part of our changes:
    
        DrillbitContext context = ...
        DrillClient client = DrillClient.builder( )
            .fromContext( context )
            .build( );
    
    Doing the above might simplify test code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message