drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #565: DRILL-4841: Use server event loop for web clients
Date Thu, 06 Oct 2016 22:08:11 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/565#discussion_r82264416
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
    @@ -89,79 +88,175 @@
     import com.google.common.annotations.VisibleForTesting;
     import com.google.common.base.Strings;
     import com.google.common.util.concurrent.AbstractCheckedFuture;
    +import com.google.common.util.concurrent.MoreExecutors;
     import com.google.common.util.concurrent.SettableFuture;
     
     /**
      * Thin wrapper around a UserClient that handles connect/close and transforms
      * String into ByteBuf.
    + *
    + * To create non-default objects, use {@link DrillClient.Builder the builder class}.
    + * E.g.
    + * <code>
    + *   DrillClient client = DrillClient.newBuilder()
    + *       .setConfig(...)
    + *       .setIsDirectConnection(true)
    --- End diff --
    
    setDirectConnection
    
    The "setIs" form is rather awkward. The typical convention is:
    
    setSomething( boolean flag )
    boolean isSomething( )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message