drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gparai <...@git.apache.org>
Subject [GitHub] drill pull request #604: DRILL-4862: binary_string should use another buffer...
Date Thu, 06 Oct 2016 22:02:14 GMT
Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/604#discussion_r82293808
  
    --- Diff: common/src/main/java/org/apache/drill/common/util/DrillStringUtils.java ---
    @@ -160,10 +160,9 @@ private static void appendByte(StringBuilder result, byte b) {
        *
        * @return Index in the byte buffer just after the last written byte.
        */
    -  public static int parseBinaryString(ByteBuf str, int strStart, int strEnd) {
    -    int length = (strEnd - strStart);
    -    int dstEnd = strStart;
    -    for (int i = strStart; i < strStart+length ; i++) {
    +  public static int parseBinaryString(ByteBuf str, int strStart, int strEnd, ByteBuf
out) {
    +    int dstEnd = 0;
    +    for (int i = strStart; i < strEnd ; i++) {
    --- End diff --
    
    Please change to `strEnd;`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message