drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paul-rogers <...@git.apache.org>
Subject [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Date Thu, 06 Oct 2016 19:14:09 GMT
Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r82252246
  
    --- Diff: distribution/src/resources/sqlline.bat ---
    @@ -114,6 +114,10 @@ if "test%DRILL_LOG_DIR%" == "test" (
       set DRILL_LOG_DIR=%DRILL_HOME%\log
     )
     
    +if "test%DRILL_TMP_DIR%" == "test" (
    +  set DRILL_TMP_DIR=\tmp
    --- End diff --
    
    On Windows, I think the standard is to use %TEMP%. There generally is no directory called
"\tmp", sometimes there is a "\temp". But %TEMP% is the accepted practice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message