drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly
Date Tue, 04 Oct 2016 11:35:21 GMT
Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/595#discussion_r81736781
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -918,18 +916,22 @@ public void setMax(Object max) {
         @JsonProperty public ConcurrentHashMap<ColumnTypeMetadata_v2.Key, ColumnTypeMetadata_v2>
columnTypeInfo;
         @JsonProperty List<ParquetFileMetadata_v2> files;
         @JsonProperty List<String> directories;
    -    @JsonProperty String drillVersion;
    --- End diff --
    
    I agree regarding future similar issues. So I returned this field to `ParquetTableMetadataBase`
in the new commit. 
    But to determine that the parquet file is new and definitely with correct date values
we have a new flag in parquet metadata "is.date.correct = true". Thus, it is more easy to
determine corrupted date values and there is no need to wait the end of release to merge these
changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message