drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chunhui-shi <...@git.apache.org>
Subject [GitHub] drill pull request #594: DRILL-4842: SELECT * on JSON data results in Number...
Date Mon, 03 Oct 2016 20:06:28 GMT
Github user chunhui-shi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/594#discussion_r81627752
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
    @@ -56,6 +58,12 @@
       private final boolean readNumbersAsDouble;
     
       /**
    +   * Collection for tracking nullable fields during reading
    +   * and storing them for creating default typed vectors
    +   */
    +  private final Set<String> nullableFields  = Sets.newLinkedHashSet();
    --- End diff --
    
    I don't see the reason you need it to be a LinkedHashSet. And if there is no particular
reason for it, making it LinkedHashSet but not HashSet adds extra cost.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message