Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4BE75200B89 for ; Wed, 7 Sep 2016 08:13:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 4A8E0160ACE; Wed, 7 Sep 2016 06:13:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 91578160AA9 for ; Wed, 7 Sep 2016 08:13:58 +0200 (CEST) Received: (qmail 18693 invoked by uid 500); 7 Sep 2016 06:13:57 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 18682 invoked by uid 99); 7 Sep 2016 06:13:57 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Sep 2016 06:13:57 +0000 Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 011CA1A0046 for ; Wed, 7 Sep 2016 06:13:56 +0000 (UTC) Received: by mail-wm0-f46.google.com with SMTP id 1so12220222wmz.1 for ; Tue, 06 Sep 2016 23:13:56 -0700 (PDT) X-Gm-Message-State: AE9vXwPUHjpBzwiX19CCOVS6OT3HjiWXpXZ/PZyY/SyiV/vYCRtvy1wAWf7fJ1gmZGqNzvAVaAdUwy/DYEgliutd X-Received: by 10.28.238.88 with SMTP id m85mr1955274wmh.92.1473228834722; Tue, 06 Sep 2016 23:13:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.14.66 with HTTP; Tue, 6 Sep 2016 23:13:54 -0700 (PDT) In-Reply-To: References: From: Aman Sinha Date: Tue, 6 Sep 2016 23:13:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [DISCUSS] - Design Docs To: dev Content-Type: multipart/alternative; boundary=001a1146acc65e2ca6053be4d1e5 archived-at: Wed, 07 Sep 2016 06:13:59 -0000 --001a1146acc65e2ca6053be4d1e5 Content-Type: text/plain; charset=UTF-8 +1 on using a design doc template for features that are of moderate or higher complexity. Many of the sections are optional, so it should hopefully be considered 'lightweight' enough to encourage more people to adopt it. On Tue, Sep 6, 2016 at 10:22 PM, Khurram Faraaz wrote: > Should we have the Document history table at the beginning of the document, > that way reviewers and readers of the design document will know if the > document has already gone through a few review cycles ? > > On Wed, Sep 7, 2016 at 7:28 AM, Gautam Parai wrote: > > > Thanks so much for writing design documents for complex projects! They > are > > very helpful in learning about Drill Internals especially for new > > contributors like me - most recently Drill 4280. > > > > The design document template [2] looks good to me. > > > > For the reviews, I like Google Docs since it makes the document easy to > > share and review :) > > > > Gautam > > > > > > On Tue, Sep 6, 2016 at 5:49 PM, Parth Chandra wrote: > > > > > We had a discussion on the dev list nearly a year ago about getting > > better > > > at documenting designs in Drill [1]. We were all mostly in agreement > > that > > > we should write better design documents and I just wanted to revisit > the > > > topic. > > > > > > Some of the more complex features being worked on recently, DRILL-4800 > > and > > > DRILL-4820 to name a couple, have used a common format for the design, > > and > > > it has proven to be quite useful. > > > > > > I've put a basic template at [2]. Do folks have any comments about the > > > template? I would like to encourage folks working on complex features > to > > > use this as a guideline to writing design proposals and for reviewers > to > > > use while reviewing. I don't think every JIRA needs a design document > > > (sometimes the JIRA is enough), and I would leave it open for the > > > contributor to use whatever technology they feel comfortable with > > (provided > > > reviewers can comment easily). > > > > > > What do people think? If everyone agrees I would like to provide a link > > to > > > this document from the Contribute to Drill page. > > > > > > > > > Parth > > > > > > > > > [1] > > > http://mail-archives.apache.org/mod_mbox/drill-dev/201510. > > > mbox/%3CCAAOiHjFDOZE%2Br2zmn%2BYWF%3DbKc4JAocVKGcvaCpfTj0gXdfxLUw > > > %40mail.gmail.com%3E > > > [2] > > > https://docs.google.com/document/d/1PnBiOMV5mYBi5N6fLci- > > > bRTva1gieCuxwlSYH9crMhU/edit?usp=sharing > > > > > > --001a1146acc65e2ca6053be4d1e5--