Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A00AE200B99 for ; Wed, 21 Sep 2016 07:14:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9E9E3160AC5; Wed, 21 Sep 2016 05:14:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D06A4160AC9 for ; Wed, 21 Sep 2016 07:14:49 +0200 (CEST) Received: (qmail 29703 invoked by uid 500); 21 Sep 2016 05:14:48 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 29163 invoked by uid 99); 21 Sep 2016 05:14:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Sep 2016 05:14:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D50F0E08F2; Wed, 21 Sep 2016 05:14:47 +0000 (UTC) From: gparai To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request #593: Add flag for end of line monitoring Content-Type: text/plain Message-Id: <20160921051447.D50F0E08F2@git1-us-west.apache.org> Date: Wed, 21 Sep 2016 05:14:47 +0000 (UTC) archived-at: Wed, 21 Sep 2016 05:14:50 -0000 Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/593#discussion_r79761498 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextInput.java --- @@ -273,7 +278,7 @@ public final byte nextChar() throws IOException { byte byteChar = PlatformDependent.getByte(bStartMinus1 + bufferPtr); if (bufferPtr >= length) { - if (length != -1) { + if(length != -1) { --- End diff -- Don't remove the space- if ( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---