Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: gparai <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-578-drill@git.apache.org>
In-Reply-To: <git-pr-578-drill@git.apache.org>
Subject: [GitHub] drill pull request #578: DRILL-4280: Kerberos Authentication
Content-Type: text/plain
Message-Id: <20160903020746.2FA18E04BA@git1-us-west.apache.org>
Date: Sat,  3 Sep 2016 02:07:46 +0000 (UTC)
archived-at: Sat, 03 Sep 2016 02:07:48 -0000

Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r77429451
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/AuthenticationMechanismFactory.java ---
    @@ -0,0 +1,182 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.rpc.security;
    +
    +import com.google.common.base.Function;
    +import com.google.common.base.Strings;
    +import com.google.common.collect.Iterators;
    +import com.google.common.collect.Sets;
    +import org.apache.drill.common.AutoCloseables;
    +import org.apache.drill.common.config.DrillConfig;
    +import org.apache.drill.common.map.CaseInsensitiveMap;
    +import org.apache.drill.common.scanner.persistence.ScanResult;
    +import org.apache.drill.exec.exception.DrillbitStartupException;
    +import org.apache.drill.exec.rpc.security.kerberos.KerberosMechanism;
    +import org.apache.drill.exec.rpc.security.plain.PlainMechanism;
    +import org.apache.drill.exec.rpc.user.security.UserAuthenticator;
    +import org.apache.drill.exec.rpc.user.security.UserAuthenticatorFactory;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.fs.CommonConfigurationKeys;
    +import org.apache.hadoop.security.UserGroupInformation;
    +
    +import javax.annotation.Nullable;
    +import java.io.IOException;
    +import java.lang.reflect.Constructor;
    +import java.lang.reflect.InvocationTargetException;
    +import java.util.Collection;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +public class AuthenticationMechanismFactory implements AutoCloseable {
    +  private static final org.slf4j.Logger logger =
    +      org.slf4j.LoggerFactory.getLogger(AuthenticationMechanismFactory.class);
    +
    +  private final Map<String, AuthenticationMechanism> mechanisms = CaseInsensitiveMap.newHashMapWithExpectedSize(5);
    +
    +  @SuppressWarnings("unchecked")
    +  public AuthenticationMechanismFactory(final ScanResult scan, final DrillConfig config,
    +                                        final List<String> configuredMechanisms)
    +      throws DrillbitStartupException {
    +    logger.debug("Configuring authentication mechanisms: {}", configuredMechanisms);
    +    // transform all names to uppercase
    +    final Set<String> configuredMechanismsSet = Sets.newHashSet(Iterators.transform(configuredMechanisms.iterator(),
    +        new Function<String, String>() {
    +          @Nullable
    +          @Override
    +          public String apply(@Nullable String input) {
    +            return input == null ? null : input.toUpperCase();
    +          }
    +        }));
    +
    +    // First, load Drill provided out-of-box mechanisms
    +    if (configuredMechanismsSet.contains(PlainMechanism.SIMPLE_NAME)) {
    +      logger.trace("Plain mechanism enabled.");
    +      // instantiated here, but closed in PlainMechanism#close
    +      final UserAuthenticator userAuthenticator = UserAuthenticatorFactory.createAuthenticator(config, scan);
    +      mechanisms.put(PlainMechanism.SIMPLE_NAME, new PlainMechanism(userAuthenticator));
    +      configuredMechanismsSet.remove(PlainMechanism.SIMPLE_NAME);
    +    }
    +
    +    if (configuredMechanismsSet.contains(KerberosMechanism.SIMPLE_NAME)) {
    +      logger.trace("Kerberos mechanism enabled.");
    +      final String servicePrincipal = config.getString("drill.exec.security.auth.principal");
    +      final String keytab = config.getString("drill.exec.security.auth.keytab");
    +
    +      try { // Kerberos mechanism requires a service to login
    +        final Configuration conf = new Configuration();
    +        conf.set(CommonConfigurationKeys.HADOOP_SECURITY_AUTHENTICATION, "KERBEROS");
    +        // To parse non-typical principal name, uncomment below line
    +        // CommonConfigurationKeys.HADOOP_SECURITY_AUTH_TO_LOCAL, rules);
    +        UserGroupInformation.setConfiguration(conf);
    +        UserGroupInformation.loginUserFromKeytab(servicePrincipal, keytab);
    +        logger.trace("Login successful for user: {}", servicePrincipal);
    +      } catch (IOException e) {
    +        throw new DrillbitStartupException("Drillbit service login failed", e);
    --- End diff --
    
    Rather than failing with an exception can we simply not add Kerberos to the list of mechanisms i.e. we do not error out but rather add valid mechanisms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---