Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: paul-rogers <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-574-drill@git.apache.org>
In-Reply-To: <git-pr-574-drill@git.apache.org>
Subject: [GitHub] drill pull request #574: DRILL-4726: Dynamic UDFs support
Content-Type: text/plain
Message-Id: <20160902225424.0595DE056F@git1-us-west.apache.org>
Date: Fri,  2 Sep 2016 22:54:24 +0000 (UTC)
archived-at: Fri, 02 Sep 2016 22:54:26 -0000

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77422631
  
    --- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
    @@ -297,4 +297,44 @@ SqlNode SqlDescribeSchema() :
        {
             return new SqlDescribeSchema(pos, schema);
        }
    +}
    --- End diff --
    
    Looks fine conceptually, but have someone double-check this who is more familiar with the details of the parser implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---