drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben-Zvi <...@git.apache.org>
Subject [GitHub] drill pull request #585: DRILL-3898 : Sort spill was modified to catch all e...
Date Sat, 10 Sep 2016 01:10:22 GMT
GitHub user Ben-Zvi opened a pull request:

    https://github.com/apache/drill/pull/585

    DRILL-3898 :  Sort spill was modified to catch all errors, ignore rep…

    …eated errors while closing the new group and issue a more detailed error message.
    
    Seems that the spilling IO can run into various kinds of errors (no space, failure to
create a file,..) which are thrown as different exception classes. Hence changed the catch()
statement to catch a more general Throwable , and add the exception's message for more detail
(e.g., no disk space).
    
    Before the change the "no disk space" Throwable was not caught, and thus execution continued.
    
    Also the closing of the newGroup could hit some IO errors (e.g., when flushing), so a
try/catch was added to ignore those.
    
    Note that this change should also fix  DRILL-4542 ("if external sort fails to spill to
disk, memory is leaked and wrong error message is displayed"). 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ben-Zvi/drill DRILL-3898

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #585
    
----
commit e988f1644be1d9fde24a489d94c7dbc54f8e82d8
Author: Boaz Ben-Zvi <boaz@mapr.com>
Date:   2016-09-09T23:36:03Z

    DRILL-3898 :  Sort spill was modified to catch all errors, ignore repeated errors while
closing the new group and issue a more detailed error message.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message