drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #595: DRILL-4203: Parquet File. Date is stored wrongly
Date Thu, 29 Sep 2016 22:13:14 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/595#discussion_r81234794
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -935,6 +972,11 @@ public ColumnTypeMetadata_v2 getColumnTypeInfo(String[] name) {
         @JsonIgnore @Override public ParquetTableMetadataBase clone() {
           return new ParquetTableMetadata_v2(files, directories, columnTypeInfo);
         }
    +
    +    @JsonIgnore @Override public boolean isDateCorrect() {
    +      return isDateCorrect;
    --- End diff --
    
    What is this for? Do you bypass data checking in the cache if this is true? What if it
is not specified in the file?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message